Add Google Tag Manager in admin header #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurajaime
force-pushed
the
add/gtm_in_admin
branch
from
a13415b to
041e2a5
Compare
laurajaime
force-pushed
the
add/gtm_in_admin
branch
from
d0eac74 to
71c61ff
Compare
|
@tramuntanal can you review it again, please? |
tramuntanal
reviewed
Jun 2, 2023
README.md
Outdated
| ### Add Google Tag Manager to admin backoffice | ||
|
|
||
| Deface has a strange fail with nokogiri gem and the overrides with Deface not works with this changes. |
There was a problem hiding this comment.
Can you write the required nokogiri version in order to use deface in the HEAD tag please?
tramuntanal
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deface has a strange fail due to
nokogirigem and the overrides with Deface don't work when applied inside the HEAD tag. See:spree/deface#84
spree/spree#2633