add avalanche support #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0cte
force-pushed
the
avalanche-support
branch
4 times, most recently
from
6075ba3 to
bfae7d5
Compare
n0cte
force-pushed
the
avalanche-support
branch
from
f8a9768 to
bd5d67a
Compare
ramilexe
force-pushed
the
avalanche-support
branch
from
d8f8e1c to
7f2ff5a
Compare
…che_tidy Tidy initial avalanche impl
* add waiting bootsrapped state * add avalanche integration and add subnet creation * add implementation for subnet chains * move port binding allocation * deascrease block number for WaitForBlocks * dont send avax if subnets list is empty * revert image pulling
# Conflicts: # configuredChains.yaml # go.mod # go.sum # label/label.go
* add subnets info flag "track-subnets" * fix fn for waiting network * add subnet-evm * add WithAssumeDecided for IssueCreateSubnetTx * add timeout after import * add ignoring errors * fix err * fix subnet-evm genesis * add simple implementation for SendFunds * add validators for subnet * make 1 transaction at now * add waiting delta * stop container print evm tx hash --------- Co-authored-by: ramil <ramilexe@gmail.com>
enable image pulling
KyleMoser
reviewed
Nov 2, 2023
chain/avalanche/package.go
Outdated
| avaxAddr, _ := address.Format("X", chainId.Name, key.Address().Bytes()) | ||
| allocations := []GenesisAllocation{ | ||
| { | ||
| ETHAddr: "0x" + key.PublicKey().Address().Hex(), |
There was a problem hiding this comment.
This is a bug. These aren't ethereum addresses. Ethereum address are computed by taking the keccak256 checksum of the public key, then truncating to 20 bytes.
If you look at the code for key.PublicKey().Address(), the address function does two hashing operations. I'm not sure why but the end result is that the address is not an ethereum address.
Later in the code, during CChain genesis (node_genesis.go, NewGenesis function) the 'ETHAddr' is used in the genesis "alloc" field. So the end result, I think, is that the wrong address is put into the chain Genesis.
For comparison, if you do the following, you will get a different address than what you did here:
privateKey, err := crypto.HexToECDSA("56289e99c94b6912bfc12adc093c9b51124f0dc54ac7a766b2bc5ccf558d8027")
if err != nil {
return fmt.Errorf("can't parse private key: %s", err)
}
ethAddr := crypto.PubkeyToAddress(privateKey.PublicKey)
addrHex = ethAddr.Hex()
fmt.Printf("key addr: %s\n", addrHex)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.