Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vertx to 4.4.6 #955

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Update vertx to 4.4.6 #955

merged 2 commits into from
Dec 12, 2023

Conversation

jframe
Copy link
Contributor

@jframe jframe commented Dec 12, 2023 •
edited
Loading

PR Description

Update Vertx to 4.4.6 and suppress CVE that doesn't apply to Web3Signer

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@jframe jframe marked this pull request as ready for review December 12, 2023 01:43
usmansaleem
usmansaleem approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jframe jframe merged commit 0c95d7f into Consensys:master Dec 12, 2023
7 checks passed
@jframe jframe deleted the vertx_cve branch December 12, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usmansaleem usmansaleem usmansaleem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jframe @usmansaleem