Fix web3signer build #927
Merged
Fix web3signer build #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siladu
reviewed
Oct 11, 2023
| The other vulnerable lib is besu-metrics, which might want looking at, will see if this CVE gets flagged in besu first | ||
| file name: netty-handler-4.1.97.Final.jar | ||
| ]]></notes> | ||
| <packageUrl regex="true">^pkg:maven/io\.netty/netty\-handler@.*$</packageUrl> |
There was a problem hiding this comment.
What was the reason for loosening the package filter? I'd be concerned that this CVE might crop up in other packages even though we've only considered netty-handler
There was a problem hiding this comment.
updated with more generic netty expression.
siladu
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
~/.gradle/cachespre-populated.CVE-2023-4586as no current fix is available and our code is not directly using the netty handlers.Fixed Issue(s)
#926
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing