Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ArtifactSignature to provide signature as hex string #1036

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Refactor ArtifactSignature to provide signature as hex string #1036

merged 5 commits into from
Nov 21, 2024

Conversation

usmansaleem
Copy link
Contributor

PR Description

Refactor ArtifactSignature to provide signature as hex string. Also use generics to return signature data.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

@usmansaleem
Refactor ArtifactSignature to use asHex method to return signature
96b1a22 
 -- Remove SignatureFormatter functional interface
 -- Update SignerForIdentifier
@usmansaleem
Refactor ArtifactSignature to use asHex method to return signature
159ed01 
 -- Remove SignatureFormatter functional interface
 -- Update SignerForIdentifier
@usmansaleem
reverting artifactsignerprovider changes
3588952
@usmansaleem
Use generics with signAndGetArtifactSignature
2ca96e0
@usmansaleem usmansaleem self-assigned this Nov 21, 2024
@usmansaleem usmansaleem added the TeamCerberus Under active development by TeamCerberus @Consensys label Nov 21, 2024
@usmansaleem usmansaleem requested a review from jframe November 21, 2024 03:57
jframe
jframe approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jframe jframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem merged commit d058255 into Consensys:master Nov 21, 2024
6 checks passed
@usmansaleem usmansaleem deleted the signer_refactor branch November 21, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jframe jframe jframe approved these changes

Assignees

@usmansaleem usmansaleem

Labels
TeamCerberus Under active development by TeamCerberus @Consensys
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@usmansaleem @jframe