Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partyinfo communication-domain seperation #1117

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

melowe
Copy link
Contributor

@melowe melowe commented Aug 8, 2020

Separate all communication related classes out of tessera-partyinfo

  1. Duplicate current PartyInfo object in NodeInfo allowing the development of communication modules that can change relatively independently of business services (tessera-partyinfo)
  2. Create tessera-jaxrs/partyinfo-model module as party info object required by both sync-jaxs and thridparty
  3. Tweak tests that assert on json output not to assume node order of keys and compare a preconfigured string to output.

Note: tessera-partyinfo spring config file references classes only available at runtime due to shading. Spring has been removed in cleanup branch so its not worth the effort to address the encapsulation issue i this change.

melowe added 3 commits August 7, 2020 14:40
Expanded NodeInfo to decouple service from partyinfo which is a protocol object.
NodeInfo now duplicates the current PartyInfo but now PartyInfoService is less coupled to inbound message
Still wip but Project and all tests all build with gradle.
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2020

Codecov Report

Merging #1117 into master will decrease coverage by 0.03%.
The diff coverage is 98.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1117      +/-   ##
============================================
- Coverage     99.35%   99.32%   -0.04%     
- Complexity     2326     2353      +27     
============================================
  Files           364      369       +5     
  Lines          6516     6625     +109     
  Branches        376      380       +4     
============================================
+ Hits           6474     6580     +106     
  Misses            5        5              
- Partials         37       40       +3     
Flag Coverage Δ Complexity Δ
#unittests 99.32% <98.00%> (-0.04%) 2353.00 <36.00> (+27.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../com/quorum/tessera/partyinfo/model/Recipient.java 92.85% <ø> (ø) 10.00 <0.00> (?)
...c/main/java/com/quorum/tessera/p2p/P2PRestApp.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
...n/java/com/quorum/tessera/p2p/PartyInfoParser.java 100.00% <ø> (ø) 19.00 <0.00> (?)
...m/quorum/tessera/p2p/PartyInfoParserException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...va/com/quorum/tessera/p2p/ResendClientFactory.java 100.00% <ø> (ø) 3.00 <0.00> (?)
...a/com/quorum/tessera/p2p/ResendPartyStoreImpl.java 100.00% <ø> (ø) 6.00 <0.00> (?)
...ain/java/com/quorum/tessera/p2p/ResendRequest.java 100.00% <ø> (ø) 7.00 <0.00> (?)
...java/com/quorum/tessera/p2p/ResendRequestType.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...in/java/com/quorum/tessera/p2p/ResendResponse.java 100.00% <ø> (ø) 4.00 <0.00> (?)
.../java/com/quorum/tessera/p2p/RestResendClient.java 100.00% <ø> (ø) 3.00 <0.00> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c76c5b0...7a5b8d8. Read the comment docs.

@Krish1979 Krish1979 merged commit b7e8e0b into master Aug 10, 2020
@prd-fox prd-fox deleted the partyinfo_domain_seperation branch August 12, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants