Moving requests out of ExecutionPayload #8600
Open
+379
−1,979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests from execution payload.
lucassaldanha
changed the title
gfukushima
reviewed
Sep 19, 2024
|
|
||
| public class BeaconBlockBodyElectra extends BeaconBlockBodyAltair { | ||
|
|
||
| @JsonProperty("execution_payload") | ||
| public final ExecutionPayloadElectra executionPayload; | ||
| public final ExecutionPayloadDeneb executionPayload; |
There was a problem hiding this comment.
is it worth a comment here explaining that we use ExecutionPayloadDeneb because no changes have been introduced in Electra? It's is clear now but it might be confusing in the future.
| @@ -88,7 +91,8 @@ class BlindedBeaconBlockBodyElectraImpl | |||
| syncAggregate, | |||
| executionPayloadHeader, | |||
| blsToExecutionChanges, | |||
| blobKzgCommitments); | |||
| blobKzgCommitments, | |||
| executionRequests); | |||
There was a problem hiding this comment.
is this missing its correspondent get method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
withdrawal_requests,deposit_requestsandconsolidation_requestsfrom Execution Payload (execution payload is exactly like Deneb, removed all Electra classes for it);execution_requestsinto Beacon Block Body (Electra)Reference spec PR: https://github.com/ethereum/consensus-specs/pull/3875/files
Fixed Issue(s)
fixes #8593
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog