Rpc blobs bug fix + blobsUtil endianness + integration tests #7200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbenr
force-pushed
the
rpc_blobs_integration_test
branch
from
dfb3ea7 to
9883a9f
Compare
tbenr
changed the title
tbenr
changed the title
tbenr
force-pushed
the
rpc_blobs_integration_test
branch
from
524b849 to
ae9ac9e
Compare
StefanBratanov
approved these changes
Jun 1, 2023
...h/pegasys/teku/networking/eth2/rpc/beaconchain/methods/BlobSidecarsByRootMessageHandler.java
Show resolved
Hide resolved
| new BlobSidecarsByRangeRequestMessage( | ||
| firstSupportedSlot, | ||
| updatedCount, | ||
| spec.getMaxBlobsPerBlock(firstSupportedSlot.plus(updatedCount)) |
There was a problem hiding this comment.
should be technically .plus(updatedCount).minus(1)
There was a problem hiding this comment.
put it on the other place too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7216
fixes: #7183
fixes: #6834
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog