Post BlockContents #7082
Post BlockContents #7082
Conversation
mehdi-aouadi
force-pushed
the
7013-post-blockcontents
branch
3 times, most recently
from
40226e0 to
8dcacb1
Compare
mehdi-aouadi
force-pushed
the
7013-post-blockcontents
branch
from
8dcacb1 to
0fd78d7
Compare
...eaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/beacon/PostBlock.java
Outdated
Show resolved
Hide resolved
| return AsyncApiResponse.respondWithCode(SC_ACCEPTED); | ||
| } | ||
| })); | ||
| Object requestBody = request.getRequestBody(); |
There was a problem hiding this comment.
If im not mistaken request.getRequestBody() should be able to return you the real object so we might be able to clean this up a lot by checking request.getRequestBody() instanceof SignedBlockContents
and just calling request.getRequestBody again to pass to the submits... the Object here isn't super pretty, or the casting it causes...
There was a problem hiding this comment.
Yes, it returns the real object but we can call request.getRequestBody() only once, hence the Object and casting usage
There was a problem hiding this comment.
Maybe take a look at #7094 - i think thats probably something more like what we want, where we define the type conversion and how to identify what the string is...
There was a problem hiding this comment.
The predicate could probably equally take a parser, we'd just have to parse twice or reset it... anyway, i think that's cleaner and we can reuse it whenever we get something like this...
data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
Outdated
Show resolved
Hide resolved
...s/src/referenceTest/java/tech/pegasys/teku/reference/altair/fork/TransitionTestExecutor.java
Outdated
Show resolved
Hide resolved
...a/tech/pegasys/teku/spec/datastructures/blocks/versions/deneb/SignedBlockContentsSchema.java
Show resolved
Hide resolved
...gasys/teku/infrastructure/restapi/openapi/request/OneOfJsonRequestContentTypeDefinition.java
Outdated
Show resolved
Hide resolved
...i/src/test/java/tech/pegasys/teku/infrastructure/restapi/endpoints/EndpointMetadataTest.java
Outdated
Show resolved
Hide resolved
infrastructure/json/src/main/java/tech/pegasys/teku/infrastructure/json/JsonUtil.java
Outdated
Show resolved
Hide resolved
infrastructure/json/src/test/java/tech/pegasys/teku/infrastructure/json/JsonUtilTest.java
Outdated
Show resolved
Hide resolved
|
This would probably benefit from breaking down a bit! |
mehdi-aouadi
force-pushed
the
7013-post-blockcontents
branch
from
50501a0 to
6ae25ca
Compare
| @@ -575,6 +577,18 @@ public SafeFuture<SendSignedBlockResult> sendSignedBlock( | |||
| .exceptionally(ex -> SendSignedBlockResult.rejected(ex.getMessage())); | |||
| } | |||
|
|
|||
| @Override | |||
| public SafeFuture<SendSignedBlockResult> sendSignedBlockContents( | |||
There was a problem hiding this comment.
Would this method be chosen based on the milestone we are in? I wonder if we can fit everything in one data structure SignedBeaconBlock and SignedBlockContents so there is no additional methods.
|
Closing it for now. The data structures need to be refactored |
PR Description
Implement Deneb
PostBlockandPostBlindedBlockAPIsSpec
Fixed Issue(s)
#7013
#7075
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog