-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement BlobSidecarsAvailabilityChecker
#7018
Merged
StefanBratanov
merged 10 commits into
Consensys:master
from
StefanBratanov:blob_sidecars_availability_checker
Apr 11, 2023
Merged
Implement BlobSidecarsAvailabilityChecker
#7018
StefanBratanov
merged 10 commits into
Consensys:master
from
StefanBratanov:blob_sidecars_availability_checker
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
reviewed
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit picks
...spec/src/main/java/tech/pegasys/teku/spec/logic/versions/deneb/helpers/MiscHelpersDeneb.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/teku/spec/logic/versions/deneb/blobs/BlobSidecarsAvailabilityChecker.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/teku/spec/logic/versions/deneb/blobs/BlobSidecarsAvailabilityChecker.java
Outdated
Show resolved
Hide resolved
.../tech/pegasys/teku/statetransition/forkchoice/ForkChoiceBlobSidecarsAvailabilityChecker.java
Outdated
Show resolved
Hide resolved
StefanBratanov
force-pushed
the
blob_sidecars_availability_checker
branch
from
April 11, 2023 15:00
c58db9a
to
1486f09
Compare
tbenr
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
BlobSidecarsAvailabilityChecker
and an implementation ofForkChoiceBlobSidecarsAvailabilityChecker
MiscHelpersDeneb
to useverifyBlobKzgProofBatch
Fixed Issue(s)
resolves a task in #6822
Documentation
doc-change-required
label to this PR if updates are required.Changelog