Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BlobSidecarsAvailabilityChecker #7018

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Apr 5, 2023

PR Description

  • Introduced BlobSidecarsAvailabilityChecker and an implementation of ForkChoiceBlobSidecarsAvailabilityChecker
  • Changed MiscHelpersDeneb to use verifyBlobKzgProofBatch

Fixed Issue(s)

resolves a task in #6822

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov marked this pull request as ready for review April 5, 2023 21:16
return getBlobSidecars(new SlotAndBlockRoot(block.getSlot(), block.getRoot()));
}

SafeFuture<List<BlobSidecar>> getBlobSidecars(SlotAndBlockRoot slotAndBlockRoot);

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'slotAndBlockRoot' is never used.
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit picks

@StefanBratanov StefanBratanov force-pushed the blob_sidecars_availability_checker branch from c58db9a to 1486f09 Compare April 11, 2023 15:00
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) April 11, 2023 17:05
@StefanBratanov StefanBratanov merged commit d1347e2 into Consensys:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants