Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify proposer boost amount calculation #6814

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Simplify proposer boost amount calculation #6814

merged 1 commit into from
Feb 14, 2023

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Feb 14, 2023 •
edited
Loading

This simplification reflects ethereum/consensus-specs#3246

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (matches the spec). Just nits (ammount -> amount, semplification -> simplification)

@tbenr tbenr changed the title Simplify proposer boost ammount calculation Simplify proposer boost amount calculation Feb 14, 2023
@tbenr
Copy link
Contributor Author

tbenr commented Feb 14, 2023

Thanks for reviewing my broken english.

@tbenr tbenr merged commit d24aa47 into Consensys:master Feb 14, 2023
@tbenr tbenr deleted the simplify_proposer_boost_ammount_calculation branch February 14, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @StefanBratanov