Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar / formatting fixes. #8

Merged
merged 1 commit into from
Nov 16, 2016
Merged

Grammar / formatting fixes. #8

merged 1 commit into from
Nov 16, 2016

Conversation

joelburget
Copy link
Contributor

No description provided.

@joelburget
Copy link
Contributor Author

Additional points:

  • There are several links to the wiki on the README, but it currently has no content.
  • The README mentions the v field having 0x16 but it's actually 0x25 unless I missed something
  • The contributing section needs a lot of work. It doesn't really say anything right now -- very unclear.
  • There was a mention of private / public contracts having v of 27 or 28 / 37 or 38, but no explanation of why.
  • The section in the docs on supported / unsupported transactions was unclear.

@patrickmn patrickmn merged commit ef93d58 into master Nov 16, 2016
@patrickmn patrickmn deleted the formatting branch November 17, 2016 19:46
trung referenced this pull request in trung/quorum Nov 27, 2018
@amalrajmani
Merge pull request #8 from SatpalSandhu61/geth-upgrade-1.8.12-revert-…
2f74406 
…estimategas-fix

Revert fix for eth_estimateGas due to side-effect where attempt to pu…
apratt3377 pushed a commit to apratt3377/quorum that referenced this pull request Mar 29, 2019
@trung
Merge pull request Consensys#8 from QuorumEngineering/storePrivacyMet…
fae8e88 
…adata

Store privacy metadata
vsmk98 pushed a commit that referenced this pull request Mar 25, 2020
@vedhavyas @gballet
Add packing for dynamic array and slice types (#18051)
92639b6 
* added tests for new abi encoding features (#4)

* added tests from bytes32[][] and string[]

* added offset to other types

* formatting

* Abi/dynamic types (#5)

* Revert "Abi/dynamic types (#5)" (#6)

This reverts commit dabca31d797623d43bd780721fc0ad461d24be53.

* Abi/dynamic types (#7)

* some cleanup

* Apply suggestions from code review

apply suggestions

Co-Authored-By: vedhavyas <vedhavyas.singareddi@gmail.com>

* added better formatting (#8)

* review chnages

* better comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickmn patrickmn patrickmn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joelburget @patrickmn