-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go and dependency upgrades #1707
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travis, build: update Go to 1.20 (cherry picked from commit 5ccc99b)
build: update to go 1.21 (cherry picked from commit 55c5f5964d8cf46a73409ceb002898322295bac8)
io/ioutil touches a large amount of the codebase so is a not-insignificant change to remedy. For now ignore these lint errors as ioutil now only operates as a simple delegate for the preferred os and io packages anyway. If we want to correctly resolve these lint issues, upstream PR ethereum/go-ethereum#24869 can provide guidance.
Okay to ignore as this only affects test code and we want to minimise production code change as much as possible
(cherry picked from commit 101587b)
Krish1979
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.