Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sw_emulated test #889

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix sw_emulated test #889

merged 1 commit into from
Oct 24, 2023

Conversation

secure12
Copy link
Contributor

@secure12 secure12 commented Oct 24, 2023

Description

The doc_test.go in sw_emulated was not passing. Fixed the curve being used in the circuit, the witness points (use the computed Q instead of the base point) and added expected outputs.

Fixes #888

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • go fmt
  • go vet
  • go test doc_test.go

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yelhousni yelhousni merged commit 05be4ac into Consensys:master Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example code for emulated elliptic curve group operations fails
3 participants