-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: a special case for mulacc #859
Conversation
📦 ❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
📦
❌
❌
❌
❌
📦 ❌ ❌ ❌
❌ ❌
❌ ❌ ❌
❌ ❌
🚧
❌
❌ ❌ ❌ ❌
❌ ❌ ❌
❌ ❌ ❌
|
📦 ❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
❌
📦
❌
❌
❌
❌
📦 ❌ ❌ ❌
❌ ❌
❌ ❌ ❌
❌ ❌
🚧
❌
❌ ❌ ❌ ❌
❌ ❌ ❌
❌ ❌ ❌
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Description
Currently a
MulAcc
in Plonk always outputs two constraints. This PR saves one constraint for the special case ofa(b+1) = a + ab
.Type of change
How has this been tested?
TestMulAccFastTrack
infrontend/cs/scs/api_test.go
How has this been benchmarked?
Checklist:
golangci-lint
does not output errors locally