Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: implement FixedLengthSum of sha2 #821

Merged
merged 5 commits into from
May 9, 2024
Merged

Feat: implement FixedLengthSum of sha2 #821

merged 5 commits into from
May 9, 2024

Conversation

liyue201
Copy link
Contributor

Description

implement FixedLengthSum of sha2

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • TestSHA2FixedLengthSum

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@liyue201 liyue201 mentioned this pull request Aug 31, 2023
Merged
@ivokub
Copy link
Collaborator

ivokub commented Oct 13, 2023

Sorry for the delay in reviewing the PR. I'm trying to do it soon 👍 .

ivokub
ivokub approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really sorry for the delay. I had completely missed it. Looks perfect! Thanks for the contribution!

I'll wait for the CI to complete and then will merge.

@ivokub ivokub merged commit 78e19f6 into Consensys:master May 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyue201 @CLAassistant @ivokub