Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: reduce mem allocs in scs frontend #654

Merged
merged 3 commits into from
Apr 25, 2023
Merged

perf: reduce mem allocs in scs frontend #654

merged 3 commits into from
Apr 25, 2023

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Apr 20, 2023 •
edited
Loading

Example for a 1000 MiMC:

benchmark                   old ns/op     new ns/op     delta
BenchmarkCompileMiMC-10     226517208     170724021     -24.63%

benchmark                   old allocs     new allocs     delta
BenchmarkCompileMiMC-10     4101305        2656976        -35.22%

benchmark                   old bytes     new bytes     delta
BenchmarkCompileMiMC-10     363802628     181183808     -50.20%

ivokub
ivokub approved these changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbotrel gbotrel merged commit 94f1ddc into develop Apr 25, 2023
@gbotrel gbotrel deleted the perf/huntallocs branch April 25, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

@Tabaie Tabaie Awaiting requested review from Tabaie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @ivokub