Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: closes #509 api did not handle AssertIsLessOrEqual with constant as first param #511

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: closes #509 api did not handle AssertIsLessOrEqual with constant as first param #511

merged 3 commits into from
Mar 2, 2023

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Mar 1, 2023

No description provided.

@gbotrel gbotrel linked an issue Mar 1, 2023 that may be closed by this pull request
AssertIsLessOrEqual panics when first argument is an int literal #509
Closed
@akirillo
Copy link

akirillo commented Mar 1, 2023

dang you are fast dude

ivokub
ivokub approved these changes Mar 1, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a few comments about marking bits of decomposed values as boolean. It definitely doesn't hurt, but if the bits are not used, then the table of boolean variables gets bigger.

frontend/cs/r1cs/api_assertions.go Outdated Show resolved Hide resolved
frontend/cs/r1cs/api_assertions.go Outdated Show resolved Hide resolved
frontend/cs/scs/api_assertions.go Outdated Show resolved Hide resolved
ivokub
ivokub approved these changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all good 👍

@gbotrel gbotrel merged commit 02f598e into develop Mar 2, 2023
@gbotrel gbotrel deleted the fix/issue509 branch March 2, 2023 15:37
@akirillo akirillo mentioned this pull request Mar 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

@ThomasPiellard ThomasPiellard Awaiting requested review from ThomasPiellard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AssertIsLessOrEqual panics when first argument is an int literal
3 participants
@gbotrel @akirillo @ivokub