Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1227: api.AssertIsLessOrEqual incorrect behavior on R1CS with constant variable #1228

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Jul 25, 2024

No description provided.

@gbotrel gbotrel requested a review from ivokub July 25, 2024 16:13
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See the comment, maybe makes sense.

frontend/cs/r1cs/api_assertions.go Show resolved Hide resolved
@ivokub ivokub added the fuzzing Issue found using a fuzzing tool label Jul 26, 2024
@ivokub
Copy link
Collaborator

ivokub commented Jul 26, 2024

All comments resolved, good to merge 👍 . Thanks @wuestholz for reporting!

@gbotrel gbotrel merged commit 70baf16 into master Jul 26, 2024
7 checks passed
@gbotrel gbotrel deleted the fix/fuzz_or branch July 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fuzzing Issue found using a fuzzing tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: api.AssertIsLessOrEqual incorrect behavior on R1CS with constant variable
2 participants