fix: remove unconstrained and unused variables #1218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1214 removed usage of possible malicious hint value from the circuit. However, we still output the variables in circuit which are then enforced to be range checked. In gnark it leads to unnecessary constraints and in zkevm it creates problem with the external range checker as we're looking for constraints where this variables are used.
Type of change
How has this been tested?
Current CI. Only cosmetic change.
Checklist:
golangci-lint
does not output errors locally