Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unconstrained and unused variables #1218

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Jul 23, 2024

Description

PR #1214 removed usage of possible malicious hint value from the circuit. However, we still output the variables in circuit which are then enforced to be range checked. In gnark it leads to unnecessary constraints and in zkevm it creates problem with the external range checker as we're looking for constraints where this variables are used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Current CI. Only cosmetic change.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the bug Something isn't working label Jul 23, 2024
@ivokub ivokub requested a review from yelhousni July 23, 2024 11:24
@ivokub ivokub self-assigned this Jul 23, 2024
Copy link
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@ivokub ivokub merged commit 2118204 into master Jul 23, 2024
5 checks passed
@ivokub ivokub deleted the fix/unconstrained-variables branch July 23, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants