Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use subtraction with reduce in AssertIsEqual #1026

Merged
merged 2 commits into from
Jan 30, 2024
Merged

fix: use subtraction with reduce in AssertIsEqual #1026

merged 2 commits into from
Jan 30, 2024

Commits on Jan 30, 2024

  1. fix: use subtraction with reduce in AssertIsEqual 

    To show that two field elements are equal, we instead show that the difference
of the field elements is a multiple of emulated modulus. However, for computing
the difference we used non-reducing version of subtraction to avoid infinite
cycles. With the new mulmod implementation the reducing versions do not call
AssertIsEqual anymore so the infinite cycles are averted. For some edge cases
the difference may overflow scalar field and solving may fail.
    @ivokub
    ivokub committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    14816d5 View commit details
    Browse the repository at this point in the history

  2. test: add regression test

    @ivokub
    ivokub committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    78a7564 View commit details
    Browse the repository at this point in the history