Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix add QBFT/IBFT validator pages: #213 #215

Merged

Conversation

baptiste-b-pegasys
Copy link
Contributor

@baptiste-b-pegasys baptiste-b-pegasys commented Apr 21, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Update the Configure QBFT/IBFT consensus pages and Add and remove QBFT/IBFT validators tutorials to use new genesis tool instead of istanbul tools. Raised due to external feedback in #213.

Issue fixed

fixes #213
fixes #216

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2022

CLA assistant check
All committers have signed the CLA.

@baptiste-b-pegasys baptiste-b-pegasys temporarily deployed to preview April 21, 2022 06:46 Inactive
@alexandratran alexandratran self-requested a review April 21, 2022 07:07
@alexandratran alexandratran self-assigned this Apr 21, 2022
@baptiste-b-pegasys baptiste-b-pegasys marked this pull request as ready for review April 22, 2022 08:09
@baptiste-b-pegasys baptiste-b-pegasys requested a review from a team as a code owner April 22, 2022 08:09
@alexandratran alexandratran mentioned this pull request Apr 25, 2022
@alexandratran alexandratran changed the title fix add QBFT validator page: #213 fix add QBFT/IBFT validator pages: #213 Apr 25, 2022
@alexandratran alexandratran temporarily deployed to preview April 25, 2022 18:52 Inactive
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed minor edits + made parallel updates to the IBFT tutorials. LGTM.

@alexandratran alexandratran temporarily deployed to preview April 25, 2022 18:53 Inactive
@alexandratran alexandratran temporarily deployed to preview April 27, 2022 21:47 Inactive
@alexandratran alexandratran merged commit 2a51bba into Consensys:main Apr 27, 2022
@alexandratran alexandratran temporarily deployed to no-secret April 27, 2022 21:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update IBFT pages adding-removing-qbft-validators use istanbul-tools but didn't mention how to install it
4 participants