Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Migration finish #137

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Migration finish #137

merged 3 commits into from
Jun 22, 2022

Conversation

NicolasMassart
Copy link
Member

@NicolasMassart NicolasMassart commented Jun 21, 2022

Pull request checklist

Use the following template to make sure your PR fits the ConsenSys documentation standard.

Before creating the PR

Make sure that:

Describe the change

Updated the name of project to EthSigner in some files.

Note: this is the first PR on the migrated doc, so also trying that everything works well.

Issue fixed

  • Some remains of copy/paste to update to the right project name
  • Version dropdown not activated

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Github Actions workflow
  • Build and QA tools (for example, lint or vale)
  • MkDocs configuration
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

  • You've fixed any issues raised by the tests.
  • You've previewed your changes (see preview link added in the PR comments)

@NicolasMassart NicolasMassart temporarily deployed to preview June 21, 2022 14:00 Inactive
not yet setup
@NicolasMassart NicolasMassart temporarily deployed to preview June 21, 2022 14:06 Inactive
@NicolasMassart NicolasMassart requested a review from a team June 21, 2022 14:31
@NicolasMassart NicolasMassart self-assigned this Jun 21, 2022
@NicolasMassart NicolasMassart temporarily deployed to preview June 21, 2022 14:41 Inactive
@NicolasMassart NicolasMassart changed the title Fix naming Fix migration Jun 21, 2022
@NicolasMassart NicolasMassart changed the title Fix migration Migration finish Jun 21, 2022
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NicolasMassart NicolasMassart merged commit a247fac into Consensys:main Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants