Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

update to new goquorum doc #129

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

NicolasMassart
Copy link
Member

@NicolasMassart NicolasMassart commented Jan 20, 2022

Pull request checklist

Use the following list to make sure your PR fits the EthSigner doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you have fixed all the issues raised by the tests, if any.
  • you have verified the rendering of your changes on
    ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

update to new goquorum doc

Issue fixed

outdated url, see https://app.circleci.com/pipelines/github/ConsenSys/doc.ethsigner/1008/workflows/93659304-0d3b-4a82-8394-f80887d0a050/jobs/1972

Impacted parts

For content changes

  • Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

Screenshots / recording

@NicolasMassart NicolasMassart requested a review from a team January 20, 2022 08:23
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@macfarla macfarla merged commit 1d19b61 into Consensys:master Jan 20, 2022
@NicolasMassart NicolasMassart deleted the update-goquorum-url branch March 16, 2022 13:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants