Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

update transaction diagram #123

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Aug 24, 2021

Pull request checklist

Use the following list to make sure your PR fits the EthSigner doc quality standard.

Before creating the pull request

Make sure that:

After creating your pull request and tests finished

Make sure that:

  • you have fixed all the issues raised by the tests, if any.
  • you have verified the rendering of your changes on
    ReadTheDocs.org PR preview
    and updated the testing link (see Testing).

Describe the change

Update transaction diagram to replace web3js-eea with web3js-quorum and update style for consistency.

Issue fixed

fixes #115

Impacted parts

For content changes

  • [ x] Doc content
  • Doc pages organisation

For tools changes

  • CircleCI workflow
  • Build and QA tools (lint, vale,…)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • ReadTheDocs configuration
  • GitHub integration

Testing

See https://pegasys-ethsigner--123.com.readthedocs.build/en/123/Concepts/Overview/

Screenshots / recording

@alexandratran alexandratran requested a review from a team August 24, 2021 20:47
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandratran alexandratran merged commit 1056789 into Consensys:master Aug 26, 2021
@alexandratran alexandratran deleted the 115-update-diagram branch August 26, 2021 04:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagram requires updating
2 participants