polish: Optimize report generation #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues' palette command logic
…}] expression instead of using NotebookWrite This makes report generation that used to take >10-20 seconds now takes <1 second.
…lys' command palette logic
…Read cells in Chapter group This reduces the time taken by CreateDailysReport[] from ~18s to just ~5-6s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the 'Queue' and 'Daily' reports is now much faster. Some very rough numbers collected from generating reports in my main work workspace:
These speed gains were accomplished primarily by replacing NotebookObject-based calls like NotebookRead and NotebookWrite (for reading data from the source notebooks and writing it into the report notebook) with extracting data out of and constructing primitive
Notebook[..]expressions directly, which doesn't require round-trip operations to the FrontEnd.