Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR-CL-01 clarification #78

Closed
sarafacchinetti opened this issue Sep 26, 2018 · 8 comments
Closed

BR-CL-01 clarification #78

sarafacchinetti opened this issue Sep 26, 2018 · 8 comments

Comments

@sarafacchinetti
Copy link

This rule checks a list of values (UNTDID 1001) for BT-3
How these values have been selected?
Why in UBL is fatal and in CII is warning?

e.g. Value 202 "Document/message addressed, for instance, by a general contractor to the owner, in order that a direct payment be made to a subcontractor." Is this referring to an invoice?

In addition there are values which are clearly referring to a credit note. There is no distinction in ubl schematron between values referring to an “InvoiceTypeCode” and the ones referring to a “CreditnoteTypeCode”.
Maybe it could be added.

@phax
Copy link
Collaborator

phax commented Oct 12, 2018

CEN/TC 434 must decide on the basic rules; the syntaxes have to adopt them;
Link to codelist https://service.unece.org/trade/untdid/d16b/tred/tred1001.htm
Basically a subset of the codelist relevant for EN 16931 is needed

@oriol
Copy link
Collaborator

oriol commented Feb 6, 2019

The Annex A codelists 20190109 does not distinguish between codes referring to invoices and codes referring to credit notes. Should the artefacts perform this distinction, this Annex should distinguish between them.

As per the severity of the rules, any code list type business rule is considered fatal.

@sarafacchinettiIC
Copy link

ok, I don't have the lastest version of Annex A codelists but apparently in december version there was the distinction. If it changed no problem.
image

Concerning the severity of the rule it looks like is "warning" in CII
image

@oriol
Copy link
Collaborator

oriol commented Feb 6, 2019

Section 6.5.8 Code.Type of the EN says

The semantic model specifies the code list to be used for each coded business term. Codes shall be entered exactly as shown in the selected code list of the applicable syntax.

I understand from this statement that the business rules applying to code lists shall raise fatal errors and not warnings

@sarafacchinettiIC
Copy link

This code in a UBL credit note is considered as correct by CEN ubl schematron even though value 380 refers to an invoice

<cbc:CreditNoteTypeCode>380</cbc:CreditNoteTypeCode>

the same for the opposite case in a UBL invoice (code 381 meaning credit note)

<cbc:InvoiceTypeCode>381</cbc:InvoiceTypeCode>

Do you think an additional rule on CEN UBL schematron will be added to avoid this situation?

@phax
Copy link
Collaborator

phax commented Apr 3, 2019

Well, some solutions interpret Negative CreditNotes as invoices...

@MartinForsberg-Ecru
Copy link

I think it is a problem if you would use code 380 for a credit note. One argument is that such a combination wouldn't be possible to express in CII.
PEPPOL has a rule which captures this. It could be a candidate to move to EN-level.

@sarafacchinettiIC
Copy link

I agree, in my opinion this rule shall be inserted into CEN ubl schematron

oriol added a commit that referenced this issue Apr 23, 2019
@oriol oriol closed this as completed Apr 23, 2019
@phax phax added this to the v1.2 milestone Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants