Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR-IG-09 i BR-IP-09 absolute values #223

Closed
lasjan opened this issue Jul 8, 2020 · 0 comments
Closed

BR-IG-09 i BR-IP-09 absolute values #223

lasjan opened this issue Jul 8, 2020 · 0 comments
Milestone

Comments

@lasjan
Copy link

lasjan commented Jul 8, 2020

It looks that parenthesis uses in BR-IG-09 i BR-IP-09 are placed incorrectly.

(abs(xs:decimal(../cbc:TaxAmount - 1))< round((abs(xs:decimal(../cbc:TaxableAmount)) * (xs:decimal(cbc:Percent) div 100)) * 10 * 10) div 100 ) and (abs(xs:decimal(../cbc:TaxAmount + 1))> round((abs(xs:decimal(../cbc:TaxableAmount)) * (xs:decimal(cbc:Percent) div 100)) * 10 * 10) div 100 )

for TaxAmount lesser than 1 it will yield false error.

I think should follow approach presented in BR-S-09:

(abs(xs:decimal(../cbc:TaxAmount)) - 1 < round((abs(xs:decimal(../cbc:TaxableAmount)) * (xs:decimal(cbc:Percent) div 100)) * 10 * 10) div 100 ) and (abs(xs:decimal(../cbc:TaxAmount)) + 1 > round((abs(xs:decimal(../cbc:TaxableAmount)) * (xs:decimal(cbc:Percent) div 100)) * 10 * 10) div 100 )

Regards,
Marcin

@oriol oriol added this to the v1.3.3 milestone Sep 13, 2020
oriol added a commit that referenced this issue Sep 15, 2020
@oriol oriol closed this as completed Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants