feat(router): request rate limit configuration #760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces (limited) configuration options for client API request rate limiting.
Namely, it allows for configuring the maximum amount of requests per interval and interval duration.
-
maxRequests
: Maximum number of allowed user requests per reset interval.-
resetInterval
: Request count reset timeframe. Expressed in seconds.-
exceedQuotaPenaltyDuration
: Penalty duration for which to automatically block any subsequent requests once rate limit is exceeded. Expressed in seconds.I was originally going to also expose an option for configuring the timeout period in
exceedQuotaPenaltyDuration
, but given how that could allow admins that are unfamiliar with said mechanic's internals to effectively perma-ban their own, as well as others', IPs by accident, I settled on a hardcoded10s
setting for this.We should revisit the latter once the UI rework is finished, enabling this option and exposing endpoints for listing and managing active blocks.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
main
branchfix #xxx
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: