Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conduit Manifest #447

Merged
merged 23 commits into from
Dec 5, 2022
Merged

feat: Conduit Manifest #447

merged 23 commits into from
Dec 5, 2022

Conversation

kon14
Copy link
Contributor

@kon14 kon14 commented Nov 23, 2022

This PR introduces support for Conduit module declaration manifest objects as part of package.json.
Said manifest objects currently provide the following information:

  • module version
  • module dependencies

We should probably include support for detailing:

  • a module's supported features
  • feature dependencies
  • dependencies on features
  • migration state

Modules attempting to register themselves with Conduit provide their manifest file along with the registration request.
They are initially marked as pending, until their dependencies are met, at which point they receive a standardized activation gRPC request (activateModule()), allowing them to be properly brought up etc.

Also fixes grpc-sdk's isModuleUp().

BREAKING CHANGE:

Modified Conduit Config Service RPCs:
-Dropped ModuleExists()
-Dropped ModuleList()
-Refactored WatchModules() into WatchDeploymentState()
-Updated RegisterModule()

Services need also expose an ActivateModule() RPC
GetModules route return type modified.

I'm opening this up for review.
Requires further testing!

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

BREAKING CHANGE:

Modified Conduit Config Service RPCs:
-Dropped ModuleExists()
-Dropped ModuleList()
-Refactored WatchModules() into WatchDeployemntState()
-Updated RegisterModule()

Services need also expose an `ActivateModule()` RPC

GetModules route return type modified.
@kkopanidis kkopanidis changed the base branch from main to next November 25, 2022 13:30
@kon14
Copy link
Contributor Author

kon14 commented Dec 3, 2022

Updated this, moving standardized Conduit module RPCs into a separate service.
I'll update the client getters to support dynamic modules (so that eg Core can setConfig() out-of-tree modules).

@kkopanidis kkopanidis merged commit 5df910d into next Dec 5, 2022
@kkopanidis kkopanidis deleted the conduit-manifest branch December 5, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants