Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting option in core,email and router routes. #424

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

sdimitris
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

Routes which support sorting option:

  • /config/modules
  • /router/routes
  • /router/middlewares
  • /email/externalTemplates

@sdimitris sdimitris changed the title Sorting option in core and email routes. Sorting option in core,email and router routes. Nov 16, 2022
Copy link
Contributor

@kkopanidis kkopanidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only sort by name is available, name it such. The param should be sortByName and the value should be true or false or something simple in general.

@kkopanidis kkopanidis merged commit f924eb4 into main Nov 16, 2022
@kkopanidis kkopanidis deleted the get_route_sorting_pagination branch November 16, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants