Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(authentication): add qr code library for 2fa authentication #283

Merged
merged 5 commits into from
Aug 23, 2022
Merged

feat(authentication): add qr code library for 2fa authentication #283

merged 5 commits into from
Aug 23, 2022

Conversation

ChrisPdgn
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

kkopanidis
kkopanidis requested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@kkopanidis kkopanidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes discussed on call.

kon14
kon14 requested changes Aug 22, 2022
View reviewed changes
modules/authentication/src/models/User.schema.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/local.ts Outdated Show resolved Hide resolved
modules/authentication/src/handlers/local.ts Outdated Show resolved Hide resolved
kon14
kon14 requested changes Aug 23, 2022
View reviewed changes
modules/authentication/src/TwoFactorAuth.ts Outdated Show resolved Hide resolved
modules/authentication/src/TwoFactorAuth.ts Outdated Show resolved Hide resolved
@ChrisPdgn ChrisPdgn requested a review from kon14 August 23, 2022 09:09
@kkopanidis kkopanidis merged commit 37a6fa9 into main Aug 23, 2022
@kkopanidis kkopanidis deleted the auth-2fa branch August 23, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon14 kon14 kon14 approved these changes

@kkopanidis kkopanidis kkopanidis approved these changes

@Michael-Vol Michael-Vol Awaiting requested review from Michael-Vol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisPdgn @kon14 @kkopanidis