fix(authentication): wrong errors thrown in validation

modules/authentication/src/handlers/local.ts

@@ -218,16 +218,12 @@ export class LocalHandlers implements IAuthenticationStrategy {
       try {
         emailConfig = await this.grpcSdk.config.get('email');
       } catch (e) {
-        this.initialized = false;
-        throw ConduitError.forbidden(
-          'Cannot use email verification without Email module being enabled',
-        );
+        console.log('Cannot use email verification without Email module being enabled');
+        return (this.initialized = false);
       }
       if (!emailConfig.active) {
-        this.initialized = false;
-        throw ConduitError.forbidden(
-          'Cannot use email verification without Email module being enabled',
-        );
+        console.log('Cannot use email verification without Email module being enabled');
+        return (this.initialized = false);
       }
     }
     if (!this.initialized) {

modules/authentication/src/handlers/oauth2/OAuth2.ts

@@ -43,21 +43,19 @@ export abstract class OAuth2<T, S extends OAuth2Settings>
     const authConfig = ConfigController.getInstance().config;
     if (!authConfig[this.providerName].enabled) {
       console.log(`${this.providerName} not active`);
-      throw ConduitError.forbidden(`${this.providerName} auth is deactivated`);
+      return (this.initialized = false);
     }
     if (
       !authConfig[this.providerName] ||
       !authConfig[this.providerName].clientId ||
       !authConfig[this.providerName].clientSecret
     ) {
       console.log(`${this.providerName} is not active`);
-      throw ConduitError.forbidden(
-        `Cannot enable ${this.providerName} auth due to missing clientId or client secret`,
-      );
+      return (this.initialized = false);
     }
     console.log(`${this.providerName} is active`);
-    this.initialized = true;
-    return true;
+
+    return (this.initialized = true);
   }
 
   async redirect(call: ParsedRouterRequest): Promise<UnparsedRouterResponse> {

modules/authentication/src/handlers/service.ts

@@ -22,8 +22,7 @@ export class ServiceHandler implements IAuthenticationStrategy {
     const authConfig = ConfigController.getInstance().config;
     if (!authConfig.service.enabled) {
       console.error('Service not active');
-      this.initialized = false;
-      throw ConduitError.forbidden('Service auth is deactivated');
+      return (this.initialized = false);
     }
     console.log('Service is active');
     return (this.initialized = true);

modules/authentication/src/routes/routes.ts

@@ -78,7 +78,7 @@ export class AuthenticationRoutes {
               enabled = true;
               return;
             })
-            .catch();
+            .catch(e => console.error(e));
         },
       ),
     );