feat: oneliner deployment setup for Linux and Mac #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkopanidis
approved these changes
Nov 28, 2022
kkopanidis
added a commit
that referenced
this pull request
Dec 5, 2022
* feat(grpc-sdk)!: conduit manifest BREAKING CHANGE: Modified Conduit Config Service RPCs: -Dropped ModuleExists() -Dropped ModuleList() -Refactored WatchModules() into WatchDeployemntState() -Updated RegisterModule() Services need also expose an `ActivateModule()` RPC GetModules route return type modified. * fix(grpc-sdk): isModuleUp() * chore: code-factor cleanup * feat(core): update config rpc tests * fix(sms): registering admin routes before onRegister() * fix(grpc-sdk,core): core schema ownership * build: versioning change * feat: oneliner deployment setup for Linux and Mac (#451) * docs: update main readme, contributing guide (#450) * feat(authentication): teams & roles (#411) Co-authored-by: codefactor-io <support@codefactor.io> Co-authored-by: Konstantinos Feretos <konferetos@tutanota.com> Co-authored-by: chris <christinapdgn@gmail.com> * feat: get-conduit.sh --no-deploy flag (#452) * feat(database): sort option in admin doc query * fix(authentication): admin patch user twoFaMethod (#454) * build(grpc-sdk): fix build missing gRPC health check proto file (#455) * feat: expose compose container grpc ports (#456) * fix(grpc-sdk): redis url remap (#457) * feat(grpc-sdk): conduit module service * chore(grpc-sdk): import package.json using require() Co-authored-by: Konstantinos Kopanidis <kkopanidis@users.noreply.github.com> Co-authored-by: codefactor-io <support@codefactor.io> Co-authored-by: chris <christinapdgn@gmail.com> Co-authored-by: Sotiria Stefa <72135844+SotiriaSte@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-introduces the oneliner deployment bootstrap script, utilizing Conduit CLI.
It makes use of plain
shand generally attempts to be compatible across different shell setups.Works for Linux and Mac, on both arm64 and amd64, performing the following:
conduit deploy setup --configOnce merged, installing CLI and setting up a deployment on Linux/Mac should be as simple as:
sh <(curl -s https://getconduit.dev/bootstrap)Notes:
Conduit CLI is currently installed under
~/conduit/bin/conduit.On Linux we should respect Freedesktop XDG standards and use$HOME/.local/bininstead.I'll update this PR addressing the latter.
Upon further consideration, the above could prove troublesome, as even though the majority of distros adhere to freedesktop standards and respect the XDG for their bash environment, explicit zsh installations don't seem to come with
$HOME/.local/binas part of the default $PATH.Seeing as changing this one down the road is not gonna result in any significant trouble for us or the users I'm just gonna ignore this for now(?) so as not to further clutter the installation script.
This oneliner does not raise any warnings regarding missing Docker or Docker compose.That should ideally be internally handled by CLI.
Addressed in ConduitPlatform/CLI#36
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes: