-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sorting option in core,email and router routes. #424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdimitris
changed the title
Sorting option in core and email routes.
Sorting option in core,email and router routes.
Nov 16, 2022
kkopanidis
requested changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if only sort by name is available, name it such. The param should be sortByName and the value should be true or false or something simple in general.
ChrisPdgn
reviewed
Nov 16, 2022
ChrisPdgn
reviewed
Nov 16, 2022
ChrisPdgn
reviewed
Nov 16, 2022
packages/core/src/config-manager/admin/routes/GetModules.route.ts
Outdated
Show resolved
Hide resolved
ChrisPdgn
reviewed
Nov 16, 2022
packages/core/src/config-manager/admin/routes/GetModules.route.ts
Outdated
Show resolved
Hide resolved
ChrisPdgn
approved these changes
Nov 16, 2022
…ype changed to boolean
kkopanidis
force-pushed
the
get_route_sorting_pagination
branch
from
November 16, 2022 15:50
cbaddaa
to
f6e1bcd
Compare
kkopanidis
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
main
branchfix #xxx
, where "xxx" is the issue number)Routes which support sorting option: