fix(authentication): missing redirect nullity check

ConduitPlatform · Feb 28, 2024 · d292960 · d292960
1 parent 9c1d578
commit d292960
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/modules/authentication/src/handlers/local.ts b/modules/authentication/src/handlers/local.ts
@@ -493,7 +493,7 @@ export class LocalHandlers implements IAuthenticationStrategy {
     const user: User = verificationTokenDoc.user as User;
     if (isNil(user)) throw new GrpcError(status.NOT_FOUND, 'User not found');
     const redirectUri = AuthUtils.validateRedirectUri(
-      verificationTokenDoc.data.customRedirectUri,
+      verificationTokenDoc.data ? verificationTokenDoc.data.customRedirectUri : undefined,
     );
     const userPromise: Promise<User | null> = User.getInstance().findByIdAndUpdate(
       user._id,
@@ -510,9 +510,7 @@ export class LocalHandlers implements IAuthenticationStrategy {
 
     this.grpcSdk.bus?.publish('authentication:verified:user', JSON.stringify(user));
 
-    return redirectUri
-      ? { redirect: redirectUri ?? config.local.verification.redirect_uri }
-      : 'Email verified';
+    return { redirect: redirectUri ?? config.local.verification.redirect_uri };
   }
 
   async verifyChangeEmail(call: ParsedRouterRequest): Promise<UnparsedRouterResponse> {