-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic conduit init
and conduit pipelines init
commands
#1927
Conversation
@hariso I think
By having For that reason, I feel strongly opinionated that the command needs to be Update: One additional option is to have |
FWIW, I agree with raul. Also "build" suggests that something is actually building - eg. |
We discussed this at our daily sync, here's the summary
|
Not that my opinion should matter much here, but I'm curious why you dont just have the one command do both things? |
Yes, I was convinced today. There’s something that wasn’t mentioned above, which hopefully addresses @nickchomey’s latest comment. The idea behind While we don’t expect |
I forgot to mention something above. The intention behind the |
…duit into haris/conduit-init-simpler
Opinions of users always matter.:) Can you elaborate a bit more on "one command doing both things"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hariso nice work!
Only one thing I'd like to add before we ship this. Looks like there's no output when running pipelines init
. I think we should do something similar like you did on conduit init
Created directory: /Users/rb/code/conduitio/conduit/processors
Directory '/Users/rb/code/conduitio/conduit/connectors' already exists, skipping...
Directory '/Users/rb/code/conduitio/conduit/pipelines' already exists, skipping...
Configuration file written to /Users/rb/code/conduitio/conduit/conduit.yaml
Conduit has been initialized!
To quickly create an example pipeline, run 'conduit pipelines init'.
To see how you can customize your first pipeline, run 'conduit pipelines init --help'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hariso only one suggestion. Otherwise, looks good to me!
Co-authored-by: Raúl Barroso <ra.barroso@gmail.com>
Description
Closes #1924.
High-level overview of changes:
cli
with the CLI-related code.main.go
now invokes the CLI.init
andpipelines
, and one sub-command,pipelines init
.--pipelines.path
inconduit pipelines init
is now./pipelines
. This makes it easier to get started with Conduit (conduit init && conduit pipelines init
, without specifying the path). IMO, it makes sense also because the pipelines' directory is relative to the binary/working directory.Tested commands:
Quick checks