Pipeline architecture v2 (preview) #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Haris Osmanagić <haris@meroxa.io>
lovromazgon
commented
Oct 15, 2024
hariso
reviewed
Oct 18, 2024
hariso
reviewed
Oct 21, 2024
hariso
reviewed
Oct 29, 2024
raulb
approved these changes
Nov 7, 2024
|
For the record, I just resolved all open conversations so we could release this PR. |
4 tasks
|
Created issue to address what was remaining #1951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new internal pipeline architecture which in conjunction with the SDK changes (ConduitIO/conduit-connector-sdk#193) improves the pipeline throughput up to 5 times (from ~50k rec/s to ~250k rec/s). The new architecture uses a single worker per source connector which runs in its own goroutine and processes records in batches end-to-end. It lowers the overhead of passing records through channels between nodes, because the whole pipeline is executed in the same goroutine from start to end.
The improved pipeline architecture is disabled by default and can be enabled using the flag
-preview.pipeline-arch-v2. Note that the new architecture currently supports only 1 source and 1 destination per pipeline.Important
This is an isolated change, the functionality does not change unless the user supplies the flag
-preview.pipeline-arch-v2.Quick checks