Pipeline recovery: test cases #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
added a commit
that referenced
this pull request
Oct 4, 2024
* wip * implement restart method * implement restart swapping nodes * fix method calls * fix some tests * fix another test * fix test * update comment and refactor test * refactor tests (wip) * restart test WIP * remove redundant code * update test * fix test * add new tests and refactor * fix logger * cosmetic changes * move to a separate method * add tracing and fix max retries * not needed * Set -1 as infinite retries for err recovery * rename flag * goes to degraded once it exits * fix const * simpler implementation * add test case for 0 max-retries * fix test * no need to kill the tomb * typo and fix * fix exit-on-degraded when degraded * log before erroring * removes restart and uses start * clearer validation * handle recovery * Pipeline recovery: test cases (#1873) --------- Co-authored-by: Raúl Barroso <ra.barroso@gmail.com> * Pipeline recovery tests: add test pipeline, add test case (#1876) * need to return err * assign error * updated test cases * reuse method * use log.AttemptField --------- Co-authored-by: Haris Osmanagic <haris@meroxa.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and what type of change it is (new feature, bug fix, refactoring, documentation).
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Quick checks