Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add Lifecycle service #1835

Merged
merged 48 commits into from
Sep 13, 2024
Merged

refactor: Add Lifecycle service #1835

merged 48 commits into from
Sep 13, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Sep 6, 2024 •
edited
Loading

Description

This pull request creates a new lifecycle service that allows for the following:

  • Decoupling the existing pipeline service from others, such as ConnectorPlugin and Processor.
  • The main goal of this pull request is to enable the restart of a pipeline in isolation, without involving other services. This is part of the pipeline recovery work.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

lovromazgon
lovromazgon reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not bad, not bad at all 👍

pkg/provisioning/test/dest-file.txt Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/pipeline/service.go Outdated Show resolved Hide resolved
pkg/pipeline/service.go Outdated Show resolved Hide resolved
raulb
raulb commented Sep 12, 2024
View reviewed changes
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
@raulb raulb mentioned this pull request Sep 12, 2024
Closed
4 tasks
@raulb raulb requested a review from lovromazgon September 13, 2024 08:16
@raulb raulb changed the title refactor: Add Lifecycle service extracting refactor: Add Lifecycle service Sep 13, 2024
hariso
hariso reviewed Sep 13, 2024
View reviewed changes
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
@raulb raulb requested a review from hariso September 13, 2024 09:06
lovromazgon
lovromazgon reviewed Sep 13, 2024
View reviewed changes
pkg/pipeline/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
@raulb raulb requested a review from lovromazgon September 13, 2024 11:14
lovromazgon
lovromazgon reviewed Sep 13, 2024
View reviewed changes
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
raulb and others added 2 commits September 13, 2024 14:57
@raulb
pr feedback
55ba024
@raulb @lovromazgon
uses csync Map
3596fb8 
Uses ConduitIO/conduit-commons#116

Co-Authored-By: Lovro Mažgon <lovro.mazgon@gmail.com>
@raulb raulb changed the base branch from raul/recovery-mechanism to main September 13, 2024 13:52
@raulb raulb requested a review from lovromazgon September 13, 2024 13:52
@lovromazgon lovromazgon merged commit 0072ae1 into main Sep 13, 2024
3 checks passed
@lovromazgon lovromazgon deleted the raul/recovery-mechanism-refactor branch September 13, 2024 15:21
@raulb raulb mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

@hariso hariso Awaiting requested review from hariso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raulb @hariso @lovromazgon