Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add fatal errors #1811

Merged
merged 16 commits into from
Aug 30, 2024
Merged

feat: add fatal errors #1811

merged 16 commits into from
Aug 30, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Aug 28, 2024 •
edited
Loading

Description

Fixes #1780

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb force-pushed the raul/introduce-fatal-errors branch from f57f1e1 to 534d1c4 Compare August 28, 2024 11:37
@raulb raulb marked this pull request as ready for review August 28, 2024 12:07
@raulb raulb requested a review from a team as a code owner August 28, 2024 12:07
maha-hajja
maha-hajja reviewed Aug 28, 2024
View reviewed changes
pkg/foundation/cerrors/fatal.go Outdated Show resolved Hide resolved
pkg/foundation/cerrors/fatal_test.go Outdated Show resolved Hide resolved
pkg/foundation/cerrors/fatal_test.go Outdated Show resolved Hide resolved
pkg/foundation/cerrors/fatal_test.go Outdated Show resolved Hide resolved
pkg/foundation/cerrors/fatal_test.go Show resolved Hide resolved
pkg/foundation/cerrors/fatal.go Outdated Show resolved Hide resolved
@raulb raulb requested a review from maha-hajja August 29, 2024 13:52
@raulb
Copy link
Member Author

raulb commented Aug 29, 2024 •
edited
Loading

@maha-hajja I addressed all feedback I could apply, however there are still two open comments I responded to. Let me know what you think about those. Thanks for taking a look at this!

@raulb raulb requested a review from maha-hajja August 30, 2024 09:25
@raulb
Copy link
Member Author

raulb commented Aug 30, 2024

@maha-hajja addressed feedback again! Please take another look 🙏🏻

@raulb raulb requested a review from hariso August 30, 2024 09:34
hariso
hariso approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@raulb raulb merged commit 7edb34d into main Aug 30, 2024
3 checks passed
@raulb raulb deleted the raul/introduce-fatal-errors branch August 30, 2024 10:02
@raulb raulb mentioned this pull request Aug 30, 2024
Merged
4 tasks
@lovromazgon lovromazgon mentioned this pull request Sep 4, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja left review comments

@lovromazgon lovromazgon lovromazgon left review comments

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Recovery] Introduce fatal errors
4 participants
@raulb @hariso @lovromazgon @maha-hajja