-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Buf actions #1739
Update Buf actions #1739
Conversation
Looks like Buf released a new action that unifies all of these actions. I'll convert this PR to a draft. |
Also keep in mind that we need the token specifically when generating the proto code in |
I was looking at that too, but interestingly, |
The latest Buf updates on your PR. Results from workflow buf / validate (pull_request).
|
The latest Buf updates on your PR. Results from workflow buf-validate / validate (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪 Please do the same in the processor SDK, connector protocol and conduit commons, I believe we are using buf there as well.
Description
Closes #1710.
main
branch)The validation currently fails, because we haven't updated
buf.lock
when we made changes to conduit-commons (part of the schema related work in 0.11). A workflow that regularly runsbuf update
is implemented in #1772.Quick checks