Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Buf actions #1739

Merged
merged 19 commits into from
Aug 14, 2024
Merged

Update Buf actions #1739

merged 19 commits into from
Aug 14, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Aug 1, 2024

Description

Closes #1710.

  • Updates the Buf jobs (uses the new action)
  • Splits existing workflow into two separate ones:
    • one that validates changes in a pull request
    • one that pushes the changes into BSR (once they've been merged into our main branch)
  • Uses a token (that we already have set up in a secret) to authenticate requests to Buf.

The validation currently fails, because we haven't updated buf.lock when we made changes to conduit-commons (part of the schema related work in 0.11). A workflow that regularly runs buf update is implemented in #1772.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review August 1, 2024 16:39
@hariso hariso requested a review from a team as a code owner August 1, 2024 16:39
@hariso hariso changed the title Use BUF_TOKEN Add authentication token to Buf actions Aug 1, 2024
@hariso
Copy link
Contributor Author

hariso commented Aug 1, 2024

Looks like Buf released a new action that unifies all of these actions. I'll convert this PR to a draft.

@hariso hariso marked this pull request as draft August 1, 2024 16:58
@lovromazgon
Copy link
Member

Also keep in mind that we need the token specifically when generating the proto code in validate-generated-files.yml because we're using remote code generation.

@hariso
Copy link
Contributor Author

hariso commented Aug 2, 2024

Also keep in mind that we need the token specifically when generating the proto code in validate-generated-files.yml because we're using remote code generation.

I was looking at that too, but interestingly, buf isn't complaining about the token there. I plan to take a closer at that (I mean, it doesn't hurt just giving it the token, but still).

@hariso hariso changed the title Add authentication token to Buf actions Update Buf actions Aug 12, 2024
Copy link
Contributor

The latest Buf updates on your PR. Results from workflow buf / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (2)Aug 12, 2024, 8:22 PM

proto/api/v1/api.swagger.json Outdated Show resolved Hide resolved
proto/api/v1/api.proto Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 13, 2024

The latest Buf updates on your PR. Results from workflow buf-validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedAug 14, 2024, 1:43 PM

@hariso hariso marked this pull request as ready for review August 13, 2024 10:44
@hariso hariso enabled auto-merge (squash) August 13, 2024 13:14
@hariso hariso requested a review from lovromazgon August 14, 2024 13:46
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪 Please do the same in the processor SDK, connector protocol and conduit commons, I believe we are using buf there as well.

@hariso hariso merged commit 891178b into main Aug 14, 2024
5 checks passed
@hariso hariso deleted the haris/buf-login branch August 14, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Authenticate Buf actions
2 participants