Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fromJSON and toJSON for transaction payloads #319

Merged
merged 11 commits into from
Feb 2, 2024

Conversation

lassemoldrup
Copy link
Contributor

Purpose

Addresses #307.

Changes

Extends the AccountTransactionHandler interface with fromJSON and toJSON methods for converting transactions from and to JSON-serializable types.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/accountTransactions.ts Outdated Show resolved Hide resolved
packages/sdk/src/types.ts Show resolved Hide resolved
packages/sdk/src/types.ts Show resolved Hide resolved
@soerenbf soerenbf force-pushed the transaction-payloads-json branch from b8e5e20 to 3329dae Compare December 19, 2023 14:43
@lassemoldrup lassemoldrup requested a review from soerenbf January 30, 2024 13:35
@soerenbf soerenbf force-pushed the transaction-payloads-json branch from 63878d1 to 956f4fd Compare January 31, 2024 09:05
@soerenbf soerenbf force-pushed the transaction-payloads-json branch from 956f4fd to e6ba735 Compare January 31, 2024 09:29
Copy link
Collaborator

@soerenbf soerenbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

packages/sdk/src/types/DataBlob.ts Show resolved Hide resolved
@lassemoldrup lassemoldrup merged commit 03e7c3c into main Feb 2, 2024
11 checks passed
@lassemoldrup lassemoldrup deleted the transaction-payloads-json branch February 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants