Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate test easyconfig without checksums to check whether checksums.json is picked up in test_checksum_step #26

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

boegel
Copy link

@boegel boegel commented Nov 18, 2022

@mboisson Some cleanup for the tests in easybuilders#3749.

In general, it's better to avoid adding additional test easyconfigs if it can be avoided, since it complicates maintenance of the test suite, and may slow down the tests that iterate over all available test easyconfigs...

Also, I don't see the need to use checksums-test.json and copying that to checksums.json in the test, so I renamed test_ecs/t/toy/checksums-test.json to test_ecs/t/toy/checksums.json.
To avoid breaking the test_enforce_checksums, where checksums.json is not supposed to be found, I've wiped $EASYBUILD_ROBOT_PATHS in that test (since then test_ecs/t/toy is no longer consider by obtain_file while it tries to find checksums.json.

@mboisson mboisson merged commit d50bd3b into ComputeCanada:checksums_external Nov 18, 2022
@boegel boegel deleted the checksums_external branch November 18, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants