Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactore static assert #437

Merged
merged 7 commits into from
May 27, 2014
Merged

refactore static assert #437

merged 7 commits into from
May 27, 2014

Conversation

psychocoderHPC
Copy link
Member

  • use BOOST_MPL_ASSERT_MSG to evaluate static conditions
  • add PMACC_CASSERT_MSG_TYPE makro
  • extend PMACC_STATIC_ASSERT_MSG to support typeInfo
  • remove some BOOST_ASSERT with PMACC_CASSERT_MSG
  • move VillaBune static shape check from currentConfig.unitless to the solver

@psychocoderHPC psychocoderHPC added this to the Open Beta milestone May 22, 2014
@ax3l ax3l assigned ax3l and unassigned f-schmitt May 23, 2014
@ax3l ax3l mentioned this pull request May 23, 2014
Open
@ax3l
Copy link
Member

ax3l commented May 23, 2014

-> reassigned to me. pls rebase :)

f-schmitt
f-schmitt reviewed May 23, 2014
View reviewed changes
src/libPMacc/include/static_assert.hpp
* not tested by some compiler.
/** call BOOST_MPL_ASSERT_MSG and add unique id to message
* @param cond an integral constant expression
* @param msg a message those must a valid variable name (composition of characters_,A-Z,a-z)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos: msg a message which must be a valid variable name (...

@ax3l ax3l assigned f-schmitt and unassigned ax3l May 26, 2014
ax3l
ax3l reviewed May 26, 2014
View reviewed changes
src/libPMacc/include/math/vector/Vector.hpp
@@ -192,13 +192,13 @@ struct Vector : private T_Storage<T_Type, T_dim>, protected T_Accessor, protecte

HDINLINE type & y()
{
BOOST_STATIC_ASSERT(dim >= 2);
PMACC_CASSERT_MSG(math_Vector__access_to_y_is_not_allowed_DIM_lesser_than_2,dim >= 2);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...not_allowed_for_DIM_... ?

@ax3l
Copy link
Member

ax3l commented May 26, 2014

pretty cool change - I just annotated some last copy&paste errors :)

f-schmitt pushed a commit that referenced this pull request May 27, 2014
Merge pull request #437 from psychocoderHPC/topic-StaticAssert
3ce49e8 
refactore static assert
@f-schmitt f-schmitt merged commit 3ce49e8 into ComputationalRadiationPhysics:dev May 27, 2014
@psychocoderHPC psychocoderHPC deleted the topic-StaticAssert branch October 12, 2016 15:13
psychocoderHPC pushed a commit to psychocoderHPC/picongpu that referenced this pull request Oct 25, 2017
@psychocoderHPC
Squashed 'thirdParty/alpaka/' changes from 048a3d3..83f3fc6
7a96c0f 
83f3fc6 Merge pull request ComputationalRadiationPhysics#437 from BenjaminW3/topic-style-change-include-comment
6af80bf remove include comment
f2cea59 Merge pull request ComputationalRadiationPhysics#416 from psychocoderHPC/topic-relaxedConstExpr
663da24 Merge pull request ComputationalRadiationPhysics#434 from psychocoderHPC/topic-addDeclvalImpl
5d36ca3 host `constexpr` within device code
1fcaf85 Do not add -G on Debug
ace2059 add clang declval implementation
7543802 Merge pull request ComputationalRadiationPhysics#432 from BenjaminW3/topic-fix-MapIdx-test
61fced3 fix MapIdx test
7d0d8c5 Merge pull request ComputationalRadiationPhysics#429 from BenjaminW3/topic-fix-atomic-test
2d8a9d9 Merge pull request ComputationalRadiationPhysics#431 from ax3l/fix-deviceDebugSymbolsCUDA8GCC49
91959de Merge pull request ComputationalRadiationPhysics#430 from psychocoderHPC/fix-cudaWarning
f5f73cb GCC 4.9: Do not add -G on Debug
60d881f fix CUDA warning
0f69e0a replace std::min and std::max in kernel with ternary operators
cbd5db2 Merge pull request ComputationalRadiationPhysics#418 from BenjaminW3/topic-refactor-cpu-rand
6a56e8e Merge pull request ComputationalRadiationPhysics#423 from psychocoderHPC/fix-comparisonWarning
57fe354 Merge pull request ComputationalRadiationPhysics#424 from psychocoderHPC/topic-cuda9MinArchitecture
5e02bad Merge pull request ComputationalRadiationPhysics#421 from psychocoderHPC/fix-testBuildWithDynBoostLibs
6f19481 increase minimal CUDA archtitecture for CUDA 9
fd416e3 fix comparison warning in `Vec.hpp`
277a7ee fix test builds with dynamic boost lib
f9e0baf factor out MersenneTwister CPU random number generator
0d4790a Merge pull request ComputationalRadiationPhysics#413 from ax3l/topic-lastTypedefs
51b3c35 Merge pull request ComputationalRadiationPhysics#412 from BenjaminW3/topic-clean-up
e0bb8b0 Merge pull request ComputationalRadiationPhysics#396 from BenjaminW3/topic-events-CUDA
c633d4f Remove typedef
ec2b9a6 minimal clean ups
40d6b14 fix CPU event
ec282a8 add event tests for CUDA
6c4c9c1 Merge pull request ComputationalRadiationPhysics#333 from BenjaminW3/topic-clang-4_0
839ee02 clang 4.0+ native CUDA
4b87306 Merge pull request ComputationalRadiationPhysics#402 from BenjaminW3/topic-OpenMP-4-clang
0112d8f fix OpenMP 4 backend for clang
f1bce5e Merge pull request ComputationalRadiationPhysics#411 from ax3l/doc-noCUDAver
66201a5 Doc: No __CUDA_VER__
2c2c216 Merge pull request ComputationalRadiationPhysics#384 from BenjaminW3/topic-cuda-9_0
e038a82 CUDA 9.0
30c94aa Merge pull request ComputationalRadiationPhysics#410 from BenjaminW3/topic-ubuntu_16_04
4e2ecf8 use newer ubuntu images in CI
476815d Merge pull request ComputationalRadiationPhysics#408 from BenjaminW3/topic-clean-up-build-logs
ffe8d0b add UBSan blacklist items
986aec2 remove large file printing
eb395e9 Merge pull request ComputationalRadiationPhysics#407 from BenjaminW3/topic-docker
107049d create a docker image per job and cache it
99db278 fix flaky appveyor builds
aa91011 Merge pull request ComputationalRadiationPhysics#406 from BenjaminW3/topic-remove-uuid
b11958f remove boost.uuid from UBSan blacklist
3cc093a rename all stream impl members to shorter and identical names for clearness
22e8aff replace comparison of underlying event/stream with comparison of impl shared_ptr
ed3f89a remove uuid because it is unused
7dd080d Merge pull request ComputationalRadiationPhysics#404 from BenjaminW3/topic-kernel-unit-test-extension
f5dd1a9 use the 64 bit toolset on appveyor to work around out of heap space issues
4b92e4b add kernel unit tests
0e7c221 Merge pull request ComputationalRadiationPhysics#397 from BenjaminW3/topic-refactor-travis_yml
19b0ec8 refactor .travis.yml
002b359 Merge pull request ComputationalRadiationPhysics#401 from BenjaminW3/topic-clang-5
3ab46c6 add support for clang 5
d4753f8 Merge pull request ComputationalRadiationPhysics#400 from BenjaminW3/topic-drop-clang-3_8-native-CUDA
a30f1ee drop support for native CUDA compilation with clang-3.8 due to missing support of cuRand
2ed4755 Merge pull request ComputationalRadiationPhysics#386 from BenjaminW3/topic-boost-1_65
4d9e8e6 Merge pull request ComputationalRadiationPhysics#398 from psychocoderHPC/topic-hashedAtomicStlLock
7941d30 add github annotations
f1f317e add support for boost-1.65
886b1ab use `AtomicStlLock<16>`
fa31544 AtomicStlLock: use array of mutex

git-subtree-dir: thirdParty/alpaka
git-subtree-split: 83f3fc60e58a6964f03d5ce26a82569fc6456f95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@f-schmitt f-schmitt

Labels
component: PMacc in PMacc refactoring code change to improve performance or to unify a concept but does not change public API
Projects
None yet
Milestone
0.2.0: Open Beta
Development

Successfully merging this pull request may close these issues.
3 participants
@psychocoderHPC @ax3l @f-schmitt