Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openPMD: SDC globalAttributes still in /custom #219

Closed
PrometheusPi opened this issue Jan 6, 2016 · 3 comments
Closed

openPMD: SDC globalAttributes still in /custom #219

PrometheusPi opened this issue Jan 6, 2016 · 3 comments
Assignees
@ax3l
Labels
API change format change refactoring
Milestone
Version 1.4

Comments

@PrometheusPi
Copy link
Member

Global attributes written with the Serial Data Collector are written to /custom not to / as required by openPMD.
This can not be (simply) fixed by changing SDC_GROUP_CUSTOM from /custom to / in sdc_defines.hpp.
@ax3l ax3l added this to the Version 1.4/1.3.x milestone Jan 6, 2016
@ax3l ax3l changed the title OpenPMD: Serial Data Collector globalAttributes still in /custom OpenPMD: SDC globalAttributes still in /custom Jan 6, 2016
@PrometheusPi
Copy link
Member Author

If the SDC_GROUP_CUSTOM in in sdc_defines.hpp. is changed to "/", the writeGlobalAttributes() in SerialDataCollector.hpp fails. Opening the custom_group (here) fails with this exception.

@ax3l
Copy link
Member

ax3l commented Jan 15, 2016

@f-schmitt-zih do you know by coincidence how we can migrate the /custom group to / instead?

This will introduce the assumption that writeGlobalAttribute in SDC is really writing a global, attribute and not a local, rank-specific one.
We can still use the current implementation as a writeCustomAttribute for SDC.

@ax3l ax3l changed the title OpenPMD: SDC globalAttributes still in /custom openPMD: SDC globalAttributes still in /custom Apr 12, 2016
@ax3l ax3l self-assigned this Apr 12, 2016
ax3l added a commit to ax3l/libSplash that referenced this issue Apr 12, 2016
@ax3l
Close ComputationalRadiationPhysics#219 SDC GlobalAttibute Path to "/"
518f4f6 
Close ComputationalRadiationPhysics#219 by letting the `SerialDataCollector` write to
`/` by default, too.
Follow-up to the change in `1.3.0` for the PDC (see ComputationalRadiationPhysics#173).

Needed by several users to fulfill the `openPMD` standard
with serial files where they actually want to write to pathes
starting from `/`.
@ax3l
Copy link
Member

ax3l commented Apr 12, 2016

changed in https://github.com/ax3l/libSplash/tree/topic-sdcGlobalAttrPath for the 1.4.0 release.

ax3l added a commit to ax3l/libSplash that referenced this issue Apr 12, 2016
@ax3l
Close ComputationalRadiationPhysics#219 SDC GlobalAttibute Path to "/"
c3f75a2 
Close ComputationalRadiationPhysics#219 by letting the `SerialDataCollector` write to
`/` by default, too.
Follow-up to the change in `1.3.0` for the PDC (see ComputationalRadiationPhysics#173).

Needed by several users to fulfill the `openPMD` standard
with serial files where they actually want to write to pathes
starting from `/`.
ax3l added a commit to ax3l/libSplash that referenced this issue Apr 12, 2016
@ax3l
Close ComputationalRadiationPhysics#219 SDC GlobalAttibute Path to "/"
02f79d9 
Close ComputationalRadiationPhysics#219 by letting the `SerialDataCollector` write to
`/` by default, too.
Follow-up to the change in `1.3.0` for the PDC (see ComputationalRadiationPhysics#173).

Needed by several users to fulfill the `openPMD` standard
with serial files where they actually want to write to pathes
starting from `/`.
@ax3l ax3l mentioned this issue Apr 12, 2016
Merged
f-schmitt pushed a commit that referenced this issue Apr 13, 2016
Merge pull request #229 from ax3l/topic-sdcGlobalAttrPath
8773dc5 
Close #219 SDC GlobalAttibute Path to "/"
@ax3l ax3l closed this as completed in cd632e6 Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ax3l ax3l

Labels
API change format change refactoring
Projects
None yet
Milestone
Version 1.4
Development

No branches or pull requests
2 participants
@ax3l @PrometheusPi