Refactor CStringView out of os.h

ComputationalBiomechanicsLab · Jan 8, 2025 · b3ad1a9 · b3ad1a9
1 parent 22f9a27
commit b3ad1a9
Show file tree

Hide file tree

Showing 4 changed files with 129 additions and 112 deletions.
diff --git a/src/oscar/Platform/App.cpp b/src/oscar/Platform/App.cpp
@@ -436,8 +436,8 @@ namespace
 
     // computes the user's data directory and also logs it to the console for user-facing feedback
     std::filesystem::path get_current_user_dir_and_log_it(
-        CStringView organization_name,
-        CStringView application_name)
+        std::string_view organization_name,
+        std::string_view application_name)
     {
         auto rv = user_data_directory(organization_name, application_name);
         log_info("user data directory: %s", rv.string().c_str());

diff --git a/src/oscar/Platform/AppSettings.cpp b/src/oscar/Platform/AppSettings.cpp
@@ -149,7 +149,7 @@ R"(# configuration options
         std::string_view application_name,
         std::string_view application_config_file_name)
     {
-        const auto user_data_dir = user_data_directory(std::string{organization_name}, std::string{application_name});
+        const auto user_data_dir = user_data_directory(organization_name, application_name);
         auto full_path = user_data_dir / application_config_file_name;
 
         if (std::filesystem::exists(full_path)) {