Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add closures support for compilation speed #37

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Oct 4, 2024

Also removes the use of RuntimeGeneratedFunctions inside the generated function itself.

This adds the use of closures to reduce compile times.

Still todo:

  • Make closures more optional, off by default
  • Add automatic closure size
  • Make closures recursively available so even larger functions can be generated
  • Improve function generation performance, currently it is very slow, likely because of heavy usage of sets
  • Investigate how to improve the runtime performance of the generated functions when using closures. The current problem is likely too many allocations.

Fixes #33

@AntonReinhard
Copy link
Member Author

The rest of the todo items are not immediately necessary or depend on a more powerful FunctionCall object. I will postpone this to later PRs.

@AntonReinhard AntonReinhard marked this pull request as ready for review November 1, 2024 12:18
@AntonReinhard AntonReinhard merged commit 9a93eb8 into ComputableDAGs:main Nov 1, 2024
3 checks passed
@AntonReinhard AntonReinhard deleted the use_closures branch November 1, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework input assignment
1 participant