Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of PR #12569 #18

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Conversation

PoisonPhang
Copy link

@PoisonPhang PoisonPhang commented Nov 9, 2022

https://app.clickup.com/t/358r3ft

Backport of PR #12569

Auto format did indeed auto-format

Copy link

@vimukthi-git vimukthi-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PoisonPhang
Copy link
Author

I can build this branch fine, but running cargo test --all produces this result

error[E0437]: type `Event` is not a member of trait `pallet_asset_tx_payment::Config`
   --> frame/transaction-payment/asset-tx-payment/src/tests.rs:201:2
    |
201 |     type Event = Event;
    |     ^^^^^^^^^^^^^^^^^^^ not a member of trait `pallet_asset_tx_payment::Config`

For more information about this error, try `rustc --explain E0437`.

Can anyone else confirm this behavior?

@dzmitry-lahoda
Copy link

imho read the nix. do what nix does. nixify your local scripts and share with us. ci = local.

@PoisonPhang
Copy link
Author

PoisonPhang commented Nov 10, 2022

All tests pass with cargo nextest run --workflow, however, the same is not true with cargo test --all. This issue exists within the ComposableFi/substrate/polkadot-v0.9.27 branch as well. This is not present on paritytech/substrate from what me and @benluelo can tell.

After fixing the Event config, a new error (that happens as described above) happens for test_tracing

Context: Parity uses cargo nextest in their CI

imho read the nix. do what nix does. nixify your local scripts and share with us. ci = local.

I need to re-partition my root directory before I can correctly run nix commands.

@PoisonPhang PoisonPhang merged commit 9bdc51a into polkadot-v0.9.27 Nov 10, 2022
@PoisonPhang PoisonPhang deleted the connor/fungibles-backport branch November 10, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants