scheduler pallet benchmarking #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flipchan
commented
Aug 24, 2021
runtime/picasso/src/lib.rs
Outdated
| @@ -650,7 +650,10 @@ impl scheduler::Config for Runtime { | |||
| type ScheduleOrigin = EnsureRoot<AccountId>; | |||
| type MaxScheduledPerBlock = MaxScheduledPerBlock; | |||
| // TODO: benchmark for runtime | |||
| type WeightInfo = (); | |||
| type WeightInfo = scheduler::weights::SubstrateWeight<Runtime>; | |||
There was a problem hiding this comment.
This needs to change to weights::scheduler
There was a problem hiding this comment.
Suggested change
| type WeightInfo = scheduler::weights::SubstrateWeight<Runtime>; | |
| type WeightInfo = weights::scheduler::SubstrateWeight<Runtime>; |
|
this is super weird, when using the weight file from the pallet it works but not copying it over to the folder |
seunlanlege
suggested changes
Aug 24, 2021
runtime/picasso/src/lib.rs
Outdated
| @@ -650,7 +650,10 @@ impl scheduler::Config for Runtime { | |||
| type ScheduleOrigin = EnsureRoot<AccountId>; | |||
| type MaxScheduledPerBlock = MaxScheduledPerBlock; | |||
| // TODO: benchmark for runtime | |||
| type WeightInfo = (); | |||
| type WeightInfo = scheduler::weights::SubstrateWeight<Runtime>; | |||
There was a problem hiding this comment.
Suggested change
| type WeightInfo = scheduler::weights::SubstrateWeight<Runtime>; | |
| type WeightInfo = weights::scheduler::SubstrateWeight<Runtime>; |
|
@seunlanlege changes made |
seunlanlege
pushed a commit
that referenced
this pull request
Sep 20, 2021
…-runtime Add pallet-lending in runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is set, works only when calling the pallet directly, not works from local weights but from the pallets weights(even doe the file is the same)
WIP